feat: improvements to @stdlib/nlp-expand-contractions #497
Conversation
| "cannot": "can not", | ||
| "cant": "can not", | ||
| "cant've": "cannot have", |
There was a problem hiding this comment.
Would this not be "can not have"?
| "cannot": "can not", | ||
| "cant": "can not", | ||
| "cant've": "cannot have", | ||
| "cantve": "cannot have", |
| "couldntve": "could not have", | ||
| "couldve": "could have", | ||
| "cuppa": "cup of", | ||
| "cya": "see ya", |
| "arent": "are not", | ||
| "asap": "as soon as possible", |
There was a problem hiding this comment.
Hmm...some of these seem more like abbreviations, rather than contractions.
There was a problem hiding this comment.
True, if we go the route of strict contractions, then we need to make it clear in the README too I think. Other packages have these and I was just trying to merge everything together (so then we can review like this). Thank you for looking into all this btw.
| "bday": "birthday", | ||
| "bo's'n": "bosun", | ||
| "bo's'ns": "bosuns", | ||
| "btw": "by the way", |
There was a problem hiding this comment.
More an acronym/abbreviation than a contraction.
| "dyou": "did you", | ||
| "e'en": "even", | ||
| "e'er": "ever", | ||
| "everybody's": "everybody is", |
There was a problem hiding this comment.
This is ambiguous. Could be a possessive.
| "e'en": "even", | ||
| "e'er": "ever", | ||
| "everybody's": "everybody is", | ||
| "everyone's": "everyone is", |
| "itsn't": "it is not", | ||
| "iunno": "I do not know", | ||
| "kinda": "kind of", | ||
| "kk": "okay", |
There was a problem hiding this comment.
Also a bit tricky to distinguish a contraction from slang.
| "mayn't": "may not", | ||
| "methinks": "I think", |
There was a problem hiding this comment.
This is old English, the modern translation of which is "I think".
|
You and other maintainers are welcome to make edits / delete changes, or delete certain commits altogether if need be. |
Resolves #496