Skip to content

refactor: remove redundant code in accessor functions #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2025
Merged

refactor: remove redundant code in accessor functions #5014

merged 1 commit into from
Feb 2, 2025

Conversation

aayush0325
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
fix: remove redundant code in accessor array functions of blas/ext/ba…
3b9e655 
…se/*

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gsumkbn $\color{red}301/303$
$\color{green}+99.34\%$ 		$\color{red}20/21$
$\color{green}+95.24\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{red}301/303$
$\color{green}+99.34\%$
blas/ext/base/gsumpw $\color{red}379/395$
$\color{green}+95.95\%$ 		$\color{red}23/26$
$\color{green}+88.46\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{red}379/395$
$\color{green}+95.95\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte changed the title fix: remove redundant code in accessor array functions of blas/ext/base/* refactor: remove redundant code in accessor functions Feb 2, 2025
@kgryte kgryte added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Feb 2, 2025
@kgryte kgryte merged commit 1d1e8b7 into stdlib-js:develop Feb 2, 2025
26 of 27 checks passed
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@aayush0325 @Vinit-Pandit
refactor: remove redundant code in accessor functions
55f24b0 
PR-URL: stdlib-js#5014
Ref: stdlib-js#4960
Reviewed-by: Athan Reines <kgryte@gmail.com>
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@aayush0325 @saurabhraghuvanshii
refactor: remove redundant code in accessor functions
e36cd44 
PR-URL: stdlib-js#5014
Ref: stdlib-js#4960
Reviewed-by: Athan Reines <kgryte@gmail.com>
@aayush0325 aayush0325 deleted the fix-redundant-blas-accessor branch February 16, 2025 08:41
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @ShabiShett07
refactor: remove redundant code in accessor functions
677f571 
PR-URL: stdlib-js#5014
Ref: stdlib-js#4960
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @stdlib-bot @kgryte