Skip to content

feat: add support for accessor arrays and refactor stats/base/nanmax #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2025
Merged

feat: add support for accessor arrays and refactor stats/base/nanmax #5111

merged 3 commits into from
Feb 9, 2025

Conversation

aayush0325
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • update stats/base/nanmax to follow latest project conventions
  • add support for accessor arrays

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
refactor: update stats/base/nanmax to follow latest project conventions
3081c13 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aayush0325 aayush0325 marked this pull request as draft February 8, 2025 05:21
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Feb 8, 2025
@aayush0325 aayush0325 added the Feature Issue or pull request for adding a new feature. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 8, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/nanmax $\color{green}297/297$
$\color{green}+100.00\%$ 		$\color{green}44/44$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}297/297$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
feat: add support for accessor arrays
c4b3073 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@aayush0325 aayush0325 marked this pull request as ready for review February 9, 2025 13:29
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 9, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 9, 2025
kgryte
kgryte reviewed Feb 9, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
3906905 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 56b35d1 into stdlib-js:develop Feb 9, 2025
12 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@aayush0325 @kgryte @saurabhraghuvanshii
feat: add support for accessor arrays and refactor stats/base/nanmax
983ab43 
PR-URL: stdlib-js#5111
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@aayush0325 aayush0325 deleted the accessor-stats-nanmax branch February 16, 2025 08:46
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @kgryte @ShabiShett07
feat: add support for accessor arrays and refactor stats/base/nanmax
5f10aa1 
PR-URL: stdlib-js#5111
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @stdlib-bot @kgryte