Skip to content

Conversation

ShelbyJustyn
Copy link
Contributor

Resolves #5501.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 28, 2025
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsort2sh $\color{green}543/543$
$\color{green}+100.00\%$
$\color{green}53/53$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}543/543$
$\color{green}+100.00\%$
number/float64/base/to-words $\color{green}313/313$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}313/313$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member

@ShelbyJustyn Hey thanks for a PR on this.
Could you pls change the PR tittle to:-
chore: fix EditorConfig lint errors
As we reference the issue in the description of the PR so there would be no need to add it in the tittle.

@ShelbyJustyn ShelbyJustyn changed the title fix: linting errors in #5501 chore: fix EditorConfig lint errors Feb 28, 2025
@ShelbyJustyn
Copy link
Contributor Author

Changed the title, thank you!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 1, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 1, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: fix EditorConfig lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/5514
Closes: https://github.com/stdlib-js/stdlib/issues/5501

Co-authored-by: ShelbyJustyn <jts1414@hotmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4fdea8f into stdlib-js:develop Mar 1, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants