chore: fix EditorConfig lint errors #5543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
First-time Contributor
kgryte
reviewed
Mar 1, 2025
| ] | ||
| } | ||
| ] | ||
| "options": { |
There was a problem hiding this comment.
This should be two-space indentation, I believe.
There was a problem hiding this comment.
@Planeshifter Please don't mark things as resolved if they were not resolved. The merged commit still has 4-space indentation. See a1e8f03#diff-77e330a6681e72323e103ed003b13edc321a9ddc0b72a2460b8763e1fe4102f0R2
kgryte
reviewed
Mar 1, 2025
kgryte
reviewed
Mar 1, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 1, 2025
lib/node_modules/@stdlib/_tools/eslint/rules/no-nested-require/examples/index.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 1, 2025
lib/node_modules/@stdlib/_tools/github/user-details/lib/defaults.json
Outdated
Show resolved
Hide resolved
kgryte
added
Needs Changes
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Mar 4, 2025
stdlib-bot
removed
the
Needs Changes
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
|
Thanks, @ditsus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5526
Description
The purpose of this pull request is to fix EditorConfig linting issues with spaces and indents in the following files:
lib/node_modules/@stdlib/_tools/github/user-details/lib/defaults.json
lib/node_modules/@stdlib/error/reviver/examples/index.js
lib/node_modules/@stdlib/strided/napi/smskmap/manifest.json
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers