Skip to content

feat: refactor and add accessor protocol support to stats/base/nanrange #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2025
Merged

feat: refactor and add accessor protocol support to stats/base/nanrange #6248

merged 5 commits into from
Mar 24, 2025

Conversation

prajjwalbajpai
Copy link
Contributor

Resolves #5665.

Description

What is the purpose of this pull request?

This pull request:

  • Adds support for accessor arrays and refactor stats/base/nanrange

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@prajjwalbajpai
feat: refactored and added protocol support to stats/base/nanrange
9cdd2dd 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 21, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 21, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/nanrange $\color{green}310/310$
$\color{green}+100.00\%$ 		$\color{green}47/47$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}310/310$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@prajjwalbajpai
Copy link
Contributor Author

@aayush0325 please review

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 22, 2025
aayush0325
aayush0325 reviewed Mar 23, 2025
View reviewed changes
aayush0325
aayush0325 reviewed Mar 23, 2025
View reviewed changes
aayush0325
aayush0325 previously approved these changes Mar 23, 2025
View reviewed changes
@aayush0325 aayush0325 changed the title feat: refactored and added protocol support to stats/base/nanrange feat: refactor and add accessor protocol support to stats/base/nanrange Mar 23, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 24, 2025
kgryte
kgryte reviewed Mar 24, 2025
View reviewed changes
@kgryte
docs: update description
f1b7907 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Mar 24, 2025
View reviewed changes
@kgryte
docs: fix require order
5044ee4 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Mar 24, 2025
View reviewed changes
@kgryte
docs: fix line wrapping
24b50a1 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 24, 2025
@kgryte kgryte merged commit d9faaa4 into stdlib-js:develop Mar 24, 2025
13 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
@prajjwalbajpai @kgryte @sahil20021008
feat: refactor and add accessor protocol support to `stats/base/nanra…
babed31 
…nge`

PR-URL: stdlib-js#6248
Closes: stdlib-js#5665
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
This was referenced Apr 3, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@aayush0325 aayush0325 aayush0325 left review comments

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/nanrange
4 participants
@prajjwalbajpai @stdlib-bot @kgryte @aayush0325