Skip to content

feat: add FIF_F macro in math/base/napi/ternary #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2025
Merged

feat: add FIF_F macro in math/base/napi/ternary #6534

merged 5 commits into from
Apr 4, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds FIF_F macro in math/base/napi/ternary

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/napi/ternary $\color{green}155/155$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}155/155$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review April 3, 2025 18:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 3, 2025
@kgryte kgryte requested a review from anandkaranubc April 3, 2025 22:28
@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Apr 3, 2025
anandkaranubc
anandkaranubc reviewed Apr 4, 2025
View reviewed changes
@anandkaranubc
chore: apply suggestions from review
83bd30f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
anandkaranubc
anandkaranubc previously approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @Neerajpathak07!

kgryte
kgryte reviewed Apr 4, 2025
View reviewed changes
@kgryte
docs: update description
6068dd5 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 4, 2025
View reviewed changes
@kgryte
refactor: remove unnecessary cast
79f7631 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 4, 2025
@kgryte kgryte merged commit a321f17 into stdlib-js:develop Apr 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@anandkaranubc anandkaranubc anandkaranubc left review comments

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neerajpathak07 @stdlib-bot @kgryte @anandkaranubc