Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dmean #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 19, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dmean #6602

merged 9 commits into from
Apr 19, 2025

Conversation

gururaj1512
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dmean
  • refactors JavaScript implementation
  • refactors tests, docs, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Apr 7, 2025
@gururaj1512
Copy link
Member Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 7, 2025
@stdlib-bot
Copy link
Contributor

@gururaj1512, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 7, 2025
@gururaj1512
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 7, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 7, 2025
@gururaj1512
Copy link
Member Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 12, 2025
@stdlib-bot
Copy link
Contributor

@gururaj1512, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib make-commands - Print make commands for package changed in PR.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@gururaj1512
Copy link
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Apr 12, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dmean $\color{green}344/344$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}344/344$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gururaj1512 gururaj1512 marked this pull request as ready for review April 13, 2025 05:20
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 13, 2025
@gururaj1512
fix: minor changes
e26b584 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte reviewed Apr 19, 2025
View reviewed changes
@kgryte
style: remove backticks
747721b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2025
View reviewed changes
@kgryte
docs: fix description
f06dc2b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2025
View reviewed changes
@kgryte
docs: fix description
2dd7000 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 19, 2025
View reviewed changes
@kgryte
docs: fix description
d3c7fdb 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
fix: ensure proper suffix
70edfcb 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some minor clean-up.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Apr 19, 2025
@kgryte kgryte merged commit 29cd80a into stdlib-js:develop Apr 19, 2025
46 checks passed
@gururaj1512 gururaj1512 deleted the stats-base-dmean branch April 21, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gururaj1512 @stdlib-bot @kgryte