-
-
Notifications
You must be signed in to change notification settings - Fork 867
test: add test cases for blas/base/dgemm
#6724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShabiShett07 None of these changes are desired. You need to understand a bit more how strided storage works. Zero strides can be useful, as they allow multiple matrix elements to refer to the same underlying storage element. That means, e.g., if both strideA1
and strideA2
are both 0
, I can represent an NxN matrix in which every element is 5
with a single data buffer element. Hence, zero strides allow for compact storage.
When a matrix is read-only (and not written to), this sort of compact storage is beneficial, as it allows broadcasting values without needing to allocate memory and perform physical copies.
For dgemm
, the only matrix which should have the strideX != 0
prohibition is C
. Your checks for strideA*
and strideB*
should, however, all be removed.
ok, I am still not clear about that, but I will remove things for |
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@kgryte, removed checks for matrix |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
none
Description
This pull request:
C
forblas/base/dgemm
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers