Skip to content

feat: add ndarray/base/binary-reduce-strided1d-dispatch-factory #7950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2025
Merged

feat: add ndarray/base/binary-reduce-strided1d-dispatch-factory #7950

merged 3 commits into from
Sep 13, 2025

Conversation

gururaj1512
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • feat: add ndarray/base/binary-reduce-strided1d-dispatch-factory

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gururaj1512 gururaj1512 marked this pull request as draft August 24, 2025 08:34
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 24, 2025
@gururaj1512 gururaj1512 added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). and removed Needs Review A pull request which needs code review. labels Aug 24, 2025
@gururaj1512 gururaj1512 mentioned this pull request Aug 26, 2025
Closed
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Aug 29, 2025
@kgryte
Copy link
Member

kgryte commented Aug 29, 2025

This PR is dependent on #7908.

@kgryte
Copy link
Member

kgryte commented Sep 13, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 13, 2025
@kgryte kgryte marked this pull request as ready for review September 13, 2025 21:24
@kgryte kgryte self-requested a review September 13, 2025 21:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 13, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 13, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/binary-reduce-strided1d-dispatch-factory $\color{red}218/285$
$\color{green}+76.49\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{red}0/1$
$\color{green}+0.00\%$ 		$\color{red}218/285$
$\color{green}+76.49\%$

The above coverage report was generated for the changes in this PR.

@kgryte
chore: clean-up
9a5bb14 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: skipped
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 13, 2025
kgryte
kgryte approved these changes Sep 13, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
Copy link
Member

kgryte commented Sep 13, 2025

As the REPL lint failure is expected, I'll go ahead and merge.

@kgryte kgryte merged commit cc715fa into stdlib-js:develop Sep 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gururaj1512 @kgryte @stdlib-bot