Skip to content

Conversation

rajanarahul93
Copy link
Contributor

@rajanarahul93 rajanarahul93 commented Sep 14, 2025

Resolves #8050.

Description

What is the purpose of this pull request?

This pull request:

  • fixes two separate linting errors: a jsdoc-doctest error in @stdlib/assert/is-enumerable-property by adding missing JSDoc examples, and a no-builtin-big-int error in @stdlib/assert/has-bigint-support by refactoring to use the stdlib-approved @stdlib/bigint/ctor.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Sep 14, 2025
@rajanarahul93 rajanarahul93 force-pushed the fix-lint-doctest-bigint-8050 branch from 4b15440 to c785fec Compare September 14, 2025 09:58
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 14, 2025
@rajanarahul93 rajanarahul93 force-pushed the fix-lint-doctest-bigint-8050 branch from 6f17fde to 08fbf94 Compare September 14, 2025 15:21
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 14, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/has-bigint-support $\color{green}94/94$
$\color{green}+100.00\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}94/94$
$\color{green}+100.00\%$
assert/is-enumerable-property $\color{green}232/232$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}232/232$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Sep 14, 2025

@rajanarahul93 Please do not force push and overwrite existing changes. In doing so, you reverted changes that I had made to fix your PR. Please consult our contributing guide for tips on how to work with Git after pushing changes to a remote origin.

Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Sep 14, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Sep 14, 2025
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit 9f40b8f into stdlib-js:develop Sep 14, 2025
9 checks passed
@rajanarahul93
Copy link
Contributor Author

Understood, thank you for merging the PR. I’ll make sure not to force push or overwrite changes next time!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants