Skip to content

feat: add stats/strided/wasm/dnanvariancewd #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 17, 2025
Merged

feat: add stats/strided/wasm/dnanvariancewd #8085

merged 16 commits into from
Sep 17, 2025

Conversation

0PrashantYadav0
Copy link
Member

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Add wasm implementation for dnanvariancewd along with benchmark, docs and test.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 16, 2025
@0PrashantYadav0
fix: change in params
c101ea2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@0PrashantYadav0
fix: changes in input
92f0865 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@0PrashantYadav0
Copy link
Member Author

/stdlib-merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 16, 2025
@stdlib-bot
Copy link
Contributor

/stdlib-merge

@0PrashantYadav0, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 16, 2025
@0PrashantYadav0
fix: remove unwanted files
a5b6ff8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@0PrashantYadav0
Copy link
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. bot: In Progress Pull request is currently awaiting automation. labels Sep 16, 2025
@0PrashantYadav0 0PrashantYadav0 changed the title feat: wasm implementation for stats/strided/dnanvariancewd feat: wasm implementation for stats/strided/dnanvariancewd Sep 16, 2025
@0PrashantYadav0 0PrashantYadav0 added WebAssembly Issue involves or relates to WebAssembly. Feature Issue or pull request for adding a new feature. labels Sep 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/strided/dnanvariancewd $\color{green}390/390$
$\color{green}+100.00\%$ 		$\color{green}26/26$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}390/390$
$\color{green}+100.00\%$
stats/strided/wasm/dnanvariancewd $\color{green}562/562$
$\color{green}+100.00\%$ 		$\color{green}17/17$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}562/562$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 16, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 17, 2025
@kgryte
chore: fix lint disabling
beb2af6 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Sep 17, 2025
View reviewed changes
@kgryte
docs: remove comment
9de25db 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Sep 17, 2025
View reviewed changes
@kgryte
docs: update example
2cb16b5 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
docs: fix return value
601390c 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
17de504 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
docs: fix comment
d22a9f4 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
ac8534f 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
7e0879e 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
style: move comment
48779d4 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
docs: move comment
941d648 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@0PrashantYadav0 Be careful of copy-paste errors. There were a number of these that I needed to fix during review.

@kgryte
docs: fix missing link definition
eee176a 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte changed the title feat: wasm implementation for stats/strided/dnanvariancewd feat: add stats/strided/wasm/dnanvariancewd Sep 17, 2025
@kgryte kgryte merged commit b5ace26 into stdlib-js:develop Sep 17, 2025
17 checks passed
@0PrashantYadav0
Copy link
Member Author

@kgryte Yes sure, i was doing internal review for these changes. Next time i will open PR after internal review only.

@0PrashantYadav0 0PrashantYadav0 deleted the wasm-dnanvariancewd branch September 28, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. WebAssembly Issue involves or relates to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0PrashantYadav0 @stdlib-bot @kgryte