feat: add `dtype` option support in `ndarray/flatten` #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kgryte merged 8 commits into stdlib-js:develop from headlessNode:bug-flatten

Sep 17, 2025

Member

headlessNode commented Sep 17, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: na
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: na
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#79.

Description

What is the purpose of this pull request?

This pull request:

add dtype option support in ndarray/fatten

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add dtype option support in ndarray/flatten metr-issue-tracker#79

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          fix: add dtype option support

002775a

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---

stdlib-bot added the Needs Review label

headlessNode requested a review from kgryte

September 17, 2025 09:48

Contributor

stdlib-bot commented Sep 17, 2025 •

edited

Loading

Coverage Report

Package	Statements	Branches	Functions	Lines
ndarray/flatten	$\color{green}415/415$ $\color{green}+100.00\%$	$\color{green}28/28$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}415/415$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte changed the title ~~fix: add dtype option support in ndarray/fatten~~ fix: add dtype option support in ndarray/flatten

kgryte changed the title ~~fix: add dtype option support in ndarray/flatten~~ feat: add dtype option support in ndarray/flatten

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/flatten/docs/repl.txt Outdated Show resolved Hide resolved


          docs: update copy

fcee403

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/flatten/README.md Outdated Show resolved Hide resolved


          docs: update copy

4bc80cd

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/flatten/README.md Outdated Show resolved Hide resolved


          docs: update copy

1d3e5ff

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/flatten/docs/types/index.d.ts Outdated Show resolved Hide resolved


          docs: update copy

1e8a5be

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/flatten/test/test.js Outdated Show resolved Hide resolved

kgryte added 3 commits

September 17, 2025 03:02


          test: fix signature

c860aae

Signed-off-by: Athan <kgryte@gmail.com>


          docs: document dtype option

375b190

Signed-off-by: Athan <kgryte@gmail.com>


          refactor: avoid unnecessary dtype resolution

3146bc0

Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes

View reviewed changes

Member

kgryte left a comment

LGTM

kgryte added Feature and removed Needs Review labels

kgryte merged commit 0ed631d into stdlib-js:develop

30 checks passed

headlessNode deleted the bug-flatten branch

September 17, 2025 10:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature