-
-
Notifications
You must be signed in to change notification settings - Fork 883
feat: add stats/base/ndarray/meankbn
#8116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…) with docs, examples, tests, benchmark
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*" If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
stats/base/ndarray/meankbn
Addressed review feedback: updated README, aligned index.js and example with project conventions, and normalized package.json. Tests and example pass locally. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review! I’ve aligned the new package with project conventions by:
-
Rewriting the README to match the structure of sibling packages (Usage / Notes / Examples / See Also), fixed code fences and wording, and clarified the ndarray call shape.
-
Updating index.js and lib/index.js to include license headers, module JSDoc, and proper re-export of ./lib.
-
Making the example build a typed ndarray and print the result (mirrors ndarray/mean style).
-
Normalizing package.json fields (name, description, license, main, keywords).
-
Verifying tests/examples/benchmarks pass locally for this package.
If there are any remaining convention nits (section order, phrasing, example format, or types), I’m happy to adjust. PTAL, thanks!
Resolves #8095
Description
This pull request:
@stdlib/stats/base/ndarray/meankbn
, an ndarray wrapper around@stdlib/stats/strided/meankbn
implementing the improved Kahan–Babuška compensation algorithm;@stdlib/stats/base/ndarray/mean
(supports empty and singleton inputs, non-unit and negative strides, and non-zero offsets);ndarray/mean
, plus a numerics test demonstrating improved conditioning on[1e16, 1, -1e16]
;Related Issues
This pull request:
stats/base/ndarray/meankbn
#8095Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers