Skip to content

Conversation

prajjwalbajpai
Copy link
Contributor

@prajjwalbajpai prajjwalbajpai commented Sep 21, 2025

Resolves #8114 .

Description

What is the purpose of this pull request?

This pull request:

  • Fixes ESLint/style errors in benchmark.js for Issue Fix JavaScript lint errors #8114.
  • In lib/node_modules/@stdlib/_tools/remark/plugins/remark-run-javascript-examples/lib/main.js:
    • Disabled stdlib/jsdoc-example-require-spacing to prevent spacing error for required statement.
    • Added required path for run function and removed check for output.
  • In lib/node_modules/@stdlib/assert/is-complex-like/examples/index.js:
    • Changed the spacing to fix error.
  • In lib/node_modules/@stdlib/plot/ctor/lib/view/electron/js/debug.js:
    • Disabled stdlib/require-file-extensions from the required line.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 21, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 21, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/is-complex-like $\color{green}109/109$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}109/109$
$\color{green}+100.00\%$
plot/ctor $\color{red}1941/2243$
$\color{green}+86.54\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}0/3$
$\color{green}+0.00\%$
$\color{red}1941/2243$
$\color{green}+86.54\%$

The above coverage report was generated for the changes in this PR.

@prajjwalbajpai prajjwalbajpai marked this pull request as draft September 21, 2025 16:23
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 21, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@prajjwalbajpai prajjwalbajpai marked this pull request as ready for review September 21, 2025 17:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 21, 2025
@prajjwalbajpai
Copy link
Contributor Author

Any reviewer please guide me to resolve the failing checks.

Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 24, 2025
@kgryte
Copy link
Member

kgryte commented Sep 24, 2025

As the lint error is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit 91b52d8 into stdlib-js:develop Sep 24, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants