Skip to content

Conversation

GeoDaoyu
Copy link
Contributor

Resolves #8156.

Description

What is the purpose of this pull request?

This pull request:

  • fix C lint errors

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 29, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 29, 2025

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/assert/is-single-segment-compatible $\color{green}125/125$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}125/125$
$\color{green}+100.00\%$
ndarray/base/bytes-per-element $\color{green}118/118$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}118/118$
$\color{green}+100.00\%$
ndarray/base/numel $\color{green}92/92$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}92/92$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

* // returns 1
*/
int8_t stdlib_ndarray_is_single_segment_compatible( enum STDLIB_NDARRAY_DTYPE dtype, int64_t ndims, int64_t *shape, int64_t *strides, int64_t offset ) {
int8_t stdlib_ndarray_is_single_segment_compatible( enum STDLIB_NDARRAY_DTYPE dtype, int64_t ndims, int64_t *shape, const int64_t *strides, int64_t offset ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeoDaoyu In general, for changes such as this, you also need to update the header file and the README (if the function signature is documented there).

@kgryte kgryte self-requested a review September 29, 2025 09:33
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 29, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after making some more general changes.

@kgryte kgryte merged commit 29d3bbb into stdlib-js:develop Sep 29, 2025
11 checks passed
@GeoDaoyu GeoDaoyu deleted the fix/CLint8156 branch September 30, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants