-
-
Notifications
You must be signed in to change notification settings - Fork 892
chore: fix lint errors (#8183) #8184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Signed-off-by: Athan <kgryte@gmail.com>
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into fix-lint-errors-8183
Merge branch 'fix-lint-errors-8183' of https://github.com/Payal-Goswami/stdlib into fix-lint-errors-8183
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Thanks for merging! 🙌 I appreciate the adjustments you made - I’ll take note of them when working on future contributions. |
Resolves #8183.
Description
This pull request fixes:
Added a missing require statement for Object to satisfy the stdlib/require-globals lint rule.
Replaced the prohibited new Array() constructor with an array literal and loop push.
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers