Skip to content

Conversation

RudrakshRaina07
Copy link
Contributor

@RudrakshRaina07 RudrakshRaina07 commented Oct 14, 2025

Resolves #8235

Description

This pull request resolves two issues:

#8235 Fixed the issue of "error Unused eslint-disable directive (no problems were reported from 'no-new-wrappers')"
This pull request:

Related Issues

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Screenshot 2025-10-14 135945 Screenshot 2025-10-14 135931

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.
    -I have Read,understood and followed the contributing guidelines .

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Oct 14, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 14, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Oct 14, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 14, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/is-nonpositive-integer-array $\color{green}76/76$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}76/76$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte changed the title fixed issues #8227 #8235 chore: resolve lint errors (#8235) Oct 14, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Oct 14, 2025
@kgryte kgryte merged commit 9faaec9 into stdlib-js:develop Oct 14, 2025
20 of 21 checks passed
@RudrakshRaina07 RudrakshRaina07 deleted the hotfix branch October 14, 2025 14:04
@RudrakshRaina07 RudrakshRaina07 restored the hotfix branch October 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants