support/db: Remove ctx param from Begin/BeginTx/Rollback #3630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit removes
ctx
param fromBegin
,BeginTx
andRollback
methods ofsupport/db.Session
. It also updates Horizon to use the new method params.Why
As described in the standard
database/sql.DB.BeginTxx(ctx context.Context, opts *sql.TxOptions)
method:This behaviour interferes with
defer
edRollback
calls because in such situationROLLBACK
query is sent twice (in the internaldatabase/sql
goroutine started inBeginTxx
and insupport/db.Session.Rollback
. This can break the DB connection and make theDB
to close the connection. This can be unexpected when the app doesn't want idle DB connections to be closed.Known limitations
Other apps using
support/db
need to update the code. I couldn't find any other usages than the Horizon.