Karthik/p23 sac event support #5710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikiyer56
force-pushed
the
karthik/p23-sac-event-support
branch
from
1972985 to
df9f523
Compare
…rizon/internal/support/contractevents package
karthikiyer56
force-pushed
the
karthik/p23-sac-event-support
branch
from
c1bc508 to
0bb68b0
Compare
karthikiyer56
commented
May 26, 2025
tamirms
reviewed
May 26, 2025
tamirms
reviewed
May 26, 2025
tamirms
reviewed
May 26, 2025
…nality in horizon and processors/
karthikiyer56
commented
May 27, 2025
Shaptic
reviewed
May 27, 2025
|
apart from @Shaptic 's comments, this PR looks good to me |
Shaptic
approved these changes
May 28, 2025
| data: func() xdr.ScVal { | ||
| mapData := &xdr.ScMap{ | ||
| { | ||
| Key: xdr.ScVal{Type: xdr.ScValTypeScvSymbol, Sym: &[]xdr.ScSymbol{"to_muxed_id"}[0]}, |
There was a problem hiding this comment.
you can reuse make_symbol here, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates a new contractEvents package that is internal to horizon.
This new package accounts for events from txMetav3 and txMetav4 in accordance with the event format specified in cap-67.
The reason for the new package that is internal to horizon is because of #5669