Skip to content

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jul 25, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #5764

Adds two state archival integration tests.

One integration test addresses #5764 . The other integration test exercises a bug in stellar-core which results in an ingestion crash. Once core releases the next rc, I will update the core version in the github CI configuration and then we should expect all the integration tests to pass.

Known limitations

[N/A]

@tamirms tamirms marked this pull request as ready for review July 28, 2025 20:09
@tamirms tamirms requested a review from a team July 28, 2025 20:14
@tamirms tamirms merged commit 8c5b745 into stellar:protocol-23 Jul 29, 2025
22 checks passed
@tamirms tamirms deleted the integration-tests branch July 29, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants