-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signatures to transaction builder #109
Comments
@bartekn @brahman81 Is there a reason people can't just call |
I just can't see how pre-formed signatures will work with the new system of transaction timebounds, so I'm going to close this issue until a solution presents itself. Feel free to re-open! |
This is for multisignature accounts specifically. Imagine that there is a second signer that generated a signature for a single transaction. Then the signer sends it to you. You should be able to append a new signature to the transaction. You can't use |
Cool, that makes sense! |
- Add `Transaction.prototype.addSignature(publicKey: string, signature: string)` and `Transaction.prototype.getKeypairSIgnature(keypair: Keypair)` to allow, for example, parties to pre-sign their part of multi-signature transactions (fixes #109) - Fix syntax errors in the TransactionBuilder example code (fixes stellar/js-stellar-sdk#115)
Add a method to
TransactionBuilder
that will add existing signatures to the transaction. This will be helpful for multi-signature transactions, so one of the parties can provide a signature to be injected in a different session. Thanks @brahman81 for suggesting it.The text was updated successfully, but these errors were encountered: