Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: better formatting for README #108

Merged
merged 1 commit into from
May 3, 2023

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented May 3, 2023

This improves the Markdown formatting in multiple ways. Most notably, it nests things correctly under numbered lists, and makes the whole thing more readable as markdown, rather than needing to be rendered to HTML to be easily-readable (that's the point of Markdown, after all).

It also makes it more clear that there are two options for running the backend, and double-highlights that you need to run make build-docker, because I missed that for way too long personally 🙃

@chadoh chadoh force-pushed the docs/readme-formatting branch from b7e57a6 to afac49f Compare May 3, 2023 17:49
This improves the Markdown formatting in multiple ways. Most notably, it
nests things correctly under numbered lists, and makes the whole thing
more readable _as markdown_, rather than needing to be rendered to HTML
to be easily-readable (that's the point of Markdown, after all).

It also makes it more clear that there are two options for running the
backend, and double-highlights that you need to run `make build-docker`,
because I missed that for way too long personally 🙃

This also increases most heading sizes and uses the underline syntax for
h1 & h2, again improving readability as both markdown & html versions.
@chadoh chadoh force-pushed the docs/readme-formatting branch from afac49f to 145b74e Compare May 3, 2023 17:52
Copy link
Contributor

@tomerweller tomerweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerweller tomerweller merged commit 9697fca into stellar:main May 3, 2023
@tomerweller
Copy link
Contributor

Thanks @chadoh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants