We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When you kill soroban-rpc it may drop ongoing HTTP requests.
We should use the HTTP server graceful shutdown mechanism to finish pending HTTP requests before shutdown.
The text was updated successfully, but these errors were encountered:
We are already using gopkg.in/tylerb/graceful.v1 (through supporthttp.Run())
gopkg.in/tylerb/graceful.v1
supporthttp.Run()
Sorry, something went wrong.
Although we should probably just be using https://pkg.go.dev/net/http#Server.Shutdown directly
stellarsaur
Successfully merging a pull request may close this issue.
What problem does your feature solve?
When you kill soroban-rpc it may drop ongoing HTTP requests.
What would you like to see?
We should use the HTTP server graceful shutdown mechanism to finish pending HTTP requests before shutdown.
What alternatives are there?
The text was updated successfully, but these errors were encountered: