Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Graceful shutdown for HTTP server #499

Closed
paulbellamy opened this issue Mar 10, 2023 · 2 comments · Fixed by #566
Closed

soroban-rpc: Graceful shutdown for HTTP server #499

paulbellamy opened this issue Mar 10, 2023 · 2 comments · Fixed by #566

Comments

@paulbellamy
Copy link
Contributor

What problem does your feature solve?

When you kill soroban-rpc it may drop ongoing HTTP requests.

What would you like to see?

We should use the HTTP server graceful shutdown mechanism to finish pending HTTP requests before shutdown.

What alternatives are there?

@2opremio
Copy link
Contributor

We are already using gopkg.in/tylerb/graceful.v1 (through supporthttp.Run())

@2opremio
Copy link
Contributor

Although we should probably just be using https://pkg.go.dev/net/http#Server.Shutdown directly

@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Mar 22, 2023
@sreuland sreuland moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Mar 28, 2023
@stellarsaur stellarsaur self-assigned this Mar 28, 2023
@paulbellamy paulbellamy moved this from Current Sprint to In Progress in Platform Scrum Mar 31, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants