Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Add support for configuration from a file #507

Closed
paulbellamy opened this issue Mar 10, 2023 · 0 comments · Fixed by #609
Closed

soroban-rpc: Add support for configuration from a file #507

paulbellamy opened this issue Mar 10, 2023 · 0 comments · Fixed by #609

Comments

@paulbellamy
Copy link
Contributor

paulbellamy commented Mar 10, 2023

What problem does your feature solve?

As an operator, I'd like to be able to configure soroban-rpc from a file, so that it is easier to deploy automatically via puppet/terraform/k8s and such.

What would you like to see?

Add support for reading config from a file. Follow the patterns we use for Horizon, so it is familiar.

What alternatives are there?

Details

Create a toml configuration that would include the local configuration options. The configuration file need to be versioned, and support configuration upgrades. The effective configuration in which the soroban-rpc would work with would be determined by ( highest precedence first ):

  1. command line
  2. configuration file
  3. default configuration setting

The configuration file should internally contain a section which would be "transported" onto the captive core. That would allow the operator to configure the behaviour using a single file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants