Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-cli: add support for updated simulateTransaction responses #624

Closed
tsachiherman opened this issue May 3, 2023 · 0 comments · Fixed by #643
Closed

soroban-cli: add support for updated simulateTransaction responses #624

tsachiherman opened this issue May 3, 2023 · 0 comments · Fixed by #643

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented May 3, 2023

What ?

The rs-soroban-env now contains library functions to calculate the fees needed by a transaction, based on it's resources.
Our goal is to integrate that into simulateTransaction endpoint in soroban-rpc. This issue is about the third step in the process:
We need to update the soroban-cli to use the updated soroban-rpc simulateTransaction endpoint.

Implementation notes:

The Quickstart image with the soroban-rpc is already ready to be used. Invoke it with

docker run --rm -it -p "8000:8000" --name stellar stellar/quickstart:pr-444-soroban-dev-arm64 --standalone --enable-soroban-rpc --enable-core-artificially-accelerate-time-for-testing

Then, follow the guide in https://soroban.stellar.org/docs/getting-started/deploy-to-a-local-network, creating an account.

Last, ensure that all the following commands works:

  • soroban contract deploy
  • soroban contract install
  • soroban contract invoke
  • soroban lab token wrap

Epic

#519

@tsachiherman tsachiherman moved this from Backlog to Current Sprint in Platform Scrum May 3, 2023
@tsachiherman tsachiherman linked a pull request May 18, 2023 that will close this issue
@tsachiherman tsachiherman self-assigned this May 18, 2023
@paulbellamy paulbellamy self-assigned this May 22, 2023
@paulbellamy paulbellamy moved this from Current Sprint to In Progress in Platform Scrum May 22, 2023
@paulbellamy paulbellamy moved this from In Progress to Needs Review in Platform Scrum May 22, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants