Skip to content

Commit

Permalink
Add additional check to sep10 (#369)
Browse files Browse the repository at this point in the history
The verification of the challenge transaction is missing the check for sequence number zero.  The Utils function verifyChallengeTx mentions this in its comment, and verifies the seq number.
  • Loading branch information
msfeldstein authored and Tom Quisel committed Aug 15, 2019
1 parent 09903b1 commit f327d66
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ecosystem/sep-0010.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ To validate the challenge transaction the following steps are performed by the s
* verify that transaction contains a single [Manage Data](https://www.stellar.org/developers/guides/concepts/list-of-operations.html#manage-data) operation and it's source account is not null;
* verify that transaction envelope has a correct signature by server's signing key;
* verify that transaction envelope has a correct signature by the operation's source account;
* verify that transaction sequenceNumber is equal to zero;
* use operations's source account to determine the authenticating client and perform any additional service-specific validations.

Upon successful validation service responds with a session JWT, containing the following claims:
Expand Down

0 comments on commit f327d66

Please sign in to comment.