Add KBs for actions #1133
Add KBs for actions #1133
Conversation
…tion-security.yml to knowledge-base/actions/artiomtrjest/coverage-report-action/action-security.yml
…ion-security.yml to knowledge-base/actions/artiomtr/jest-coverage-report-action/action-security.yml
…orkflows into knowledge-base
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 13 13
Lines 1266 1266
=======================================
Hits 738 738
Misses 468 468
Partials 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks @RksRocks for the PR! Few things to note:
@Devils-Knight please confirm once you have reviewed these changes? |
|
Ok, will consider the mistakes/suggestions.
Thank you
…On Sat, 10 Sep, 2022, 9:42 pm Varun Sharma, ***@***.***> wrote:
Thanks @RksRocks <https://github.com/RksRocks> for the PR!
Few things to note:
1. The PR title should typically be Add KBs for Actions in this case.
2. Please limit KBs to 5 per PR, else it gets hard to review in one go.
@Devils-Knight <https://github.com/Devils-Knight> please confirm once you
have reviewed these changes?
—
Reply to this email directly, view it on GitHub
<#1133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWZRZSQG4Q4METTFZABUEFTV5SXODANCNFSM6AAAAAAQG6QGUM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
knowledge-base/actions/megalinter/megalinter/action-security.yml
Outdated
Show resolved
Hide resolved
| action-input: | ||
| input: github-token | ||
| is-default: true | ||
| permissions: |
There was a problem hiding this comment.
@RksRocks, I think there is:
pull-request: readpermission to check code coverage of prissues: writeto comment the code-coverage to pr
@varunsh-coder please review the permissions for this action, as some additional permission is needed for on: push trigger. check here, here.
There was a problem hiding this comment.
@varunsh-coder please review the permissions for this action, as some additional permission is needed for
on: pushtrigger. check here, here.
@varunsh-coder please review it's permission, I think it is related to this issue #1161
knowledge-base/actions/artiomtr/jest-coverage-report-action/action-security.yml
Outdated
Show resolved
Hide resolved
|
@RksRocks please also add
|
|
@varunsh-coder you can review the PR now Also look into a minor issue that I have commented on this KB. |
5 participants
Fixes #748
Fixes #753
Fixes #762
Fixes #792
Fixes #809
Fixes #810
Fixes #812