-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fix for the Linux (maybe other OSs) issue, because of depre… #318
Conversation
Based on upstream PR. See stevenlovegrove/Pangolin#318
Based on upstream PR. See stevenlovegrove/Pangolin#318
Verified this patch works to build Pangolin on 10.13.5 and ffmpeg 4 from homebrew |
Change-Id: Icb5b1a1f9253055e6125bce21dd060fb6f4c1f68
I can also confirm that this patch fixes compilation also for Pangolin master with ffmpeg 4 on macOS Sierra. |
Confirmed that this fix works for macOS HighSierra 10.13.5 |
Finally got around to testing this on my machine and cherry-picked as d9daba6 |
I still can't build it. Still getting same errors on Ubuntu 20.04 even though this patch is in master.
|
Same here, also on Ubuntu 20.04 |
…cated CONSTANTS
Hello,
I had to fix some issues on Linux (x86_64, Mint 18.3) to make it compile.
Just in case you fond it usefull, take the license you need, and thanks a lot for sharing your code :-)