Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for the Linux (maybe other OSs) issue, because of depre… #318

Closed
wants to merge 2 commits into from

Conversation

ebachard
Copy link
Contributor

@ebachard ebachard commented Jan 3, 2018

…cated CONSTANTS

Hello,

I had to fix some issues on Linux (x86_64, Mint 18.3) to make it compile.

Just in case you fond it usefull, take the license you need, and thanks a lot for sharing your code :-)

dbevans added a commit to dbevans/macports-ports that referenced this pull request May 20, 2018
dbevans added a commit to macports/macports-ports that referenced this pull request May 23, 2018
@powderluv
Copy link
Contributor

Verified this patch works to build Pangolin on 10.13.5 and ffmpeg 4 from homebrew

powderluv added a commit to powderluv/Pangolin that referenced this pull request May 24, 2018
Change-Id: Icb5b1a1f9253055e6125bce21dd060fb6f4c1f68
@NikolausDemmel
Copy link
Contributor

I can also confirm that this patch fixes compilation also for Pangolin master with ffmpeg 4 on macOS Sierra.

@TaylorDixonHD
Copy link

Confirmed that this fix works for macOS HighSierra 10.13.5

@stevenlovegrove
Copy link
Owner

Finally got around to testing this on my machine and cherry-picked as d9daba6
Thanks!

@ra0e
Copy link

ra0e commented Jun 2, 2020

I still can't build it. Still getting same errors on Ubuntu 20.04 even though this patch is in master.

 error: ‘CODEC_FLAG_GLOBAL_HEADER’ was not declared in this scope; did you mean ‘AV_CODEC_FLAG_GLOBAL_HEADER’?
  519 |         stream->codec->flags |= CODEC_FLAG_GLOBAL_HEADER;

@marcojob
Copy link

I still can't build it. Still getting same errors on Ubuntu 20.04 even though this patch is in master.

 error: ‘CODEC_FLAG_GLOBAL_HEADER’ was not declared in this scope; did you mean ‘AV_CODEC_FLAG_GLOBAL_HEADER’?
  519 |         stream->codec->flags |= CODEC_FLAG_GLOBAL_HEADER;

Same here, also on Ubuntu 20.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants