Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate routine info object to module manager #2296

Closed
hiker opened this issue Aug 29, 2023 · 2 comments
Closed

Add separate routine info object to module manager #2296

hiker opened this issue Aug 29, 2023 · 2 comments

Comments

@hiker
Copy link
Collaborator

hiker commented Aug 29, 2023 •
edited
Loading

Part of #1990.
@hiker hiker changed the title Support returning the original name of a renamed variable in VariablesAccessInfo Add separate routine info object to module manager Aug 31, 2023
@hiker hiker mentioned this issue Aug 31, 2023
Closed
hiker added a commit that referenced this issue Oct 17, 2023
@hiker
#2296 Removed modifications to example that are not required for this…
c738cef 
… PR.
hiker added a commit that referenced this issue Nov 2, 2023
@hiker
#2296 Started to move functionality from RoutineInfo to Routine.
f18b799
hiker added a commit that referenced this issue Nov 2, 2023
@hiker
#2296 Moved tests from RoutineInfo to Routine.
4805540
hiker added a commit that referenced this issue Nov 2, 2023
@hiker
#2296 Removed now unnecessary functions from RoutineInfo.
7a0136f
hiker added a commit that referenced this issue Nov 2, 2023
@hiker
#2296 Fixed failing tests.
75200d2
hiker added a commit that referenced this issue Nov 2, 2023
@hiker
#2296 Remove RoutineInfo class.
ab23f67
@arporter arporter mentioned this issue Nov 2, 2023
Merged
hiker added a commit that referenced this issue Nov 8, 2023
@hiker
#2296 Removed references to RoutineInfo.
25a2e53
hiker added a commit that referenced this issue Nov 8, 2023
@hiker
#2296 Fixed reference guide.
bc2561c
hiker added a commit that referenced this issue Nov 8, 2023
@hiker
#2296 Fixed documentation warnings.
67c8a8d
hiker added a commit that referenced this issue Nov 15, 2023
@hiker
#2296 Fixed failing test because of renaming of DynKern to LFRicKern.
0d03336
hiker added a commit that referenced this issue Nov 22, 2023
@hiker
#2296 Added CallTreeUtils.
7c8c8e8
hiker added a commit that referenced this issue Nov 22, 2023
@hiker
#2296 Remove types in driver that are not in LFRic (issue 2018).
c83a366
hiker added a commit that referenced this issue Nov 23, 2023
@hiker
#2296 Fixed test after removing r_phys.
a9cd0b5
hiker added a commit that referenced this issue Nov 23, 2023
@hiker
#2296 Updated test names.
a4f630c
hiker added a commit that referenced this issue Dec 11, 2023
@hiker
#2296 Move get_in_out_parameters to call_tree_utils.
bd2bafe
hiker added a commit that referenced this issue Dec 11, 2023
@hiker
#2296 Fix all code that used get_in_out_parameters from the Dependenc…
db91d84 
…yTools to us the CallTreeInfo.
hiker added a commit that referenced this issue Dec 12, 2023
@hiker
#2296 Removed unnecessary backslashes.
6199a63
@hiker hiker mentioned this issue Dec 23, 2023
Merged
@hiker hiker mentioned this issue Jan 9, 2024
Closed
hiker added a commit that referenced this issue Jan 15, 2024
@hiker
#2296 Fixed documentation and small bug fixes.
96d782e
hiker added a commit that referenced this issue Jan 15, 2024
@hiker
#2296 Moved function to get PSyIR of a Routine to the Container node.
e2e752c
hiker added a commit that referenced this issue Jan 15, 2024
@hiker
#2296 Added todo for replacing fparser with PSyIR.
9dc7d92
hiker added a commit that referenced this issue Jan 15, 2024
@hiker
#2296 Added #todo.
f652a9c
hiker added a commit that referenced this issue Jan 15, 2024
@hiker
#2296 Make ModuleInfo.get_psyir() return the Container, not the FileC…
37f2217 
…ontainer in preparation for supporting multiple modules per file later.
hiker added a commit that referenced this issue Jan 15, 2024
@hiker
#2296 Fixed test that got somehow corrupted.
01209b5
hiker added a commit that referenced this issue Jan 16, 2024
@hiker
#2296 Added another todo to replace one function later.
0005616
@hiker hiker mentioned this issue Jan 25, 2024
Merged
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Properly rename argument, not the function as suggested in the …
85fdfb5 
…review.
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Use new syntax for types (lower case for set, list etc)
cc7ab98
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Fixed typo.
c5c60f9
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Fixed comment.
45d9437
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Fixed typo in comment.
2204603
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Updated commends and added #TODOs.
8705c38
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Added comments to test files and updates year.
92f8ac8
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Minor changes from review.
98e8be6
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Print error messages in case of parsing errors, added test.
5540c5f
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Added todo for upcoming interface support.
89b22ef
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Added todo.
6ac000e
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Fixed typo.
fc24639
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Improved error message.
bc1d5fc
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Updated psyclone config files.
e326e6f
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Renamed 'ignore_module' to 'add_ignore_module'.
ffc0211
hiker added a commit that referenced this issue Jan 30, 2024
@hiker
#2296 Removed unused attribute.
ccbd861
hiker added a commit that referenced this issue Feb 21, 2024
@hiker
#2296 Added todo, fix minor typo.
8c2c96f
@arporter
Copy link
Member

#2367 was merged a while ago (I realise). Can this be closed @hiker?

@hiker
Copy link
Collaborator Author

hiker commented May 1, 2024

Good point - we ended up not doing it this way, but yes, closing it.

@hiker hiker closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hiker @arporter