2444 use dash instead of colon

[hiker]

A simple change that affects a lot of files. Fixes #2444.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (afed0a9) 99.85% compared to head (4980605) 99.85%.

Files	Patch %	Lines
...clone/domain/lfric/lfric_extract_driver_creator.py	98.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   99.85%   99.85%   -0.01%     
==========================================
  Files         353      354       +1     
  Lines       47459    47856     +397     
==========================================
+ Hits        47390    47786     +396     
- Misses         69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arporter]

This appears to have the CallTreeTools change in it too. Is it meant to?

[hiker]

Yes, I have 4 or so PRs lined up in a specific order. This issue eg. changes the driver names etc, so it's easier if it is done after #2296 and #1990 (and that's why I didn't label it as ready for review, but I added 'in progress' now to make this more obvious).

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (1e94cd6) to head (4aff632).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2445   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         356      356           
  Lines       48438    48438           
=======================================
  Hits        48373    48373           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hiker]

This is ready to go now. It replaces the usage of : in output files with - (: is a hassle, it needs escaping in the shell, file name completion stops at the : etc)

CI (nemo 5.0 beta passthrough) was not happy (lfric and compilation tests succeeded)

--------------------------------------------------------------------------------
Build stage BLD_SCT_PSYCLONE
--------------------------------------------------------------------------------

WARNING: /home/gh_runner/NEMOv5/tests/BENCH_PASSTHROUGH/BLD/arch_nemo.fcm: LINE 19:
         %OASIS_HOME: cyclic dependency, variable not expanded
->Parse configuration: 0 second
->Setup destination: 0 second
->Setup build: 0 second
->Pre-process: 8 seconds
->Scan dependency: 15 seconds
->Generate Fortran interface: 0 second
usage: psyclone [-h] [-oalg OALG] [-opsy OPSY] [-okern OKERN] [-api API]
                [-s SCRIPT] [-d DIRECTORY] [-I INCLUDE] [-l {off,all,output}]
                [-dm] [-nodm] [--kernel-renaming {multiple,single}]
                [--profile {invokes,routines,kernels}]
                [--backend {enable-validation,disable-validation}]
                [--config CONFIG] [--version]
                filename
[REPEATED 4 TIMES]
psyclone: error: ambiguous option: -o could match -oalg, -opsy, -okern
psyclone: error: ambiguous option: -o could match -oalg, -opsy, -okern
psyclone: error: ambiguous option: -o could match -oalg, -opsy, -okern
psyclone: error: ambiguous option: -o could match -oalg, -opsy, -okern
fcm_internal compile failed (512)
fcm_internalfcm_internal  compilecompile failed ( failed (5[125](https://github.com/stfc/PSyclone-mirror/actions/runs/9573923171/job/26396261735#step:5:126)12))

I don't think that's relates to this PR???