Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Droid] Shadows on Android not showing up #7

Closed
sthewissen opened this issue Feb 19, 2019 · 1 comment
Closed

[Droid] Shadows on Android not showing up #7

sthewissen opened this issue Feb 19, 2019 · 1 comment
Labels
help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it

Comments

@sthewissen
Copy link
Owner

sthewissen commented Feb 19, 2019

Recently noticed that the Elevation based shadows on Android don't play well with the custom background Drawable that is being set.

The problem seems to be that the Elevation values are thrown out the window as soon as a custom background Drawable is set. However, we need that custom Drawable to support all of our other features like the gradient background, rounded corners and borders. I'd expect there's a way to get the best of both worlds?

If someone has a consistent solution for getting a shadow working while using a custom background Drawable that would be great! On iOS this feature works as it should as seen in the screenshots below.

image

image

@sthewissen sthewissen added help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it labels Feb 19, 2019
@sthewissen sthewissen changed the title Shadows on Android not showing up [Droid] Shadows on Android not showing up Feb 21, 2019
@sthewissen
Copy link
Owner Author

To have the shadow show up we need to clip using the ViewOutlineProvider. This means that when we have a shadow we need to force the use of that, meaning individual corner radii are lost since the ViewOutlineProvider doesn't support those. It's a shame, but that's how it is it seems :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it
Projects
None yet
Development

No branches or pull requests

1 participant