feat: publish as @stoplight/json-schema-generator #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelltoth
commented
Sep 23, 2020
|
|
||
| exports.isNumber = function(value) { | ||
| return !exports.isArray(value) && !exports.isObject(value) && Number(value) === value && value % 1 !== 0; | ||
| return !exports.isArray(value) && !exports.isObject(value) && Number(value) === value; |
Author
There was a problem hiding this comment.
This was failing a test. It shouldn't make a difference as the only place outside of the test where this is being used is getType, and getType performs if(isInteger(x)) before it would call isNumber.
marbemac
approved these changes
Sep 23, 2020
marbemac
left a comment
marbemac
left a comment
There was a problem hiding this comment.
LGTM - assuming circle works. Can you push a small change or something to trigger circle?
And then I'd also suggest that you run release in dry run mode to sanity check, I think it's something like yarn release --dry-run? Might have to double check semantic release docs.
Author
|
Thanks for setting up CircleCI! Looks good locally, hopefully it will actually get published |
Collaborator
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here we'd like to publish our own version of this generator.
This PR sets up the package.json & the CircleCI configuration to do just that.