chore: drop url.parse and url.format

BREAKING CHANGE: WHATWG API is used in favor of url.parse & url.format

Author: P0lip

lib/bundle/util/key-generator.js

@@ -134,7 +134,7 @@ Object.assign(KeyGenerator.prototype, {
 
   generateKeyForUrl (schema, url, pathFromRoot) {
     if (!this.hasExistingGeneratedKey(schema, url)) {
-      let { path } = parse(url, true);
+      let { path } = parse(url);
       let key = path === "/" ? null : this.generateUniqueKey(schema, this.getPrettifiedKeyForFilepath(path), pathFromRoot);
 
       this.registerNewGeneratedKey(schema, url, key, pathFromRoot);

lib/resolvers/http.js

@@ -5,6 +5,7 @@ const { ono } = require("@jsdevtools/ono");
 const { AbortController } = require("node-abort-controller");
 const url = require("../util/url");
 const { ResolverError } = require("../util/errors");
+const { isBrowser } = require("../util/environment");
 
 module.exports = {
   /**
@@ -73,12 +74,7 @@ module.exports = {
    * @returns {Promise<Uint8Array | string>}
    */
   read (file) {
-    let u = url.parse(file.url);
-
-    if (process.browser && !u.protocol) {
-      // Use the protocol of the current page
-      u.protocol = url.parse(location.href).protocol;
-    }
+    let u = process.browser ? new URL(file.url, location.origin) : new URL(file.url);
 
     return download(u, this, []);
   },
@@ -87,7 +83,7 @@ module.exports = {
 /**
  * Downloads the given file.
  *
- * @param {Url|string} u        - The url to download (can be a parsed {@link Url} object)
+ * @param {URL|string} u        - The url to download (can be a parsed {@link URL} object)
  * @param {object} httpOptions  - The `options.resolve.http` object
  * @param {string[]} redirects  - The redirect URLs that have already been followed
  *
@@ -106,7 +102,7 @@ async function download (u, httpOptions, redirects) {
     headers.set("Authorization", "Basic " + btoa(u.auth));
   }
 
-  u = url.parse(url.format(Object.assign(u, { auth: "" })));
+  u.auth = "";
 
   const controller = new AbortController();
 
@@ -157,7 +153,7 @@ async function download (u, httpOptions, redirects) {
         );
       }
 
-      let redirectTo = url.resolve(u, location);
+      let redirectTo = url.resolve(u.href, location);
       return await download(redirectTo, httpOptions, redirects);
     }
 

lib/util/url.js

@@ -26,8 +26,32 @@ let urlDecodePatterns = [
   "@",
 ];
 
-exports.format = require("url").format;
-exports.parse = require("url").parse;
+class ExtendedURL extends URL {
+  get auth () {
+    return this.username + (this.password ? ":" + this.password : "");
+  }
+
+  set auth (auth) {
+    const [username, password = ""] = auth.split(":");
+    this.username = username;
+    this.password = password;
+  }
+
+  get path () {
+    return this.pathname + this.search;
+  }
+
+  get query () {
+    return Object.fromEntries(this.searchParams);
+  }
+}
+
+/**
+ *
+ * @param value {string}
+ * @returns {ExtendedURL}
+ */
+exports.parse = (value) => new ExtendedURL(value);
 exports.resolve = require("url").resolve;
 
 /**