fix: path crumbs compat with virtual scroll containers #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbemac
requested review from
a team,
Nezteb,
P0lip and
billiegoose
and removed request for
billiegoose
marbemac
commented
Dec 2, 2021
| } | ||
|
|
||
| if (node.scrollHeight > node.clientHeight) { | ||
| if (node.scrollHeight > node.clientHeight && node.clientHeight > 0) { |
There was a problem hiding this comment.
The ui-kit scroll container wraps things with a 0 height 0 width "scrollable" container (freaking weird lol), which breaks this behavior. Added this extra check to ignore 0 height parent containers, which fixes the issue (I yalc'd and confirmed this in platform).
P0lip
approved these changes
Dec 2, 2021
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. the one in legacy ui-kit that is used in Studio.