feat: perform full processing in a worker #43
Conversation
P0lip
force-pushed
the
feat/worker
branch
2 times, most recently
from
4039773 to
aaed694
Compare
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| 'plugins': ['@babel/plugin-transform-modules-commonjs'], | |||
There was a problem hiding this comment.
can you write a paragraph explaining why we need to add Babel to the ever-growing-list-of-compilers we need to support? Looks like it's only used by Jest?
There was a problem hiding this comment.
hang on I just realized this isn't studio-internal 😆 um... I'm still curious though
There was a problem hiding this comment.
It's because of of lodash-es. I suspect I should be able to instrument TS to transpile those files, though, so will give it a try.
There was a problem hiding this comment.
I see we replaced lodash - what is lodash-es doing for us?
There was a problem hiding this comment.
Rollup does not really like CJS modules, so this is the primary reason.
Lodash-es is mostly used in a worker code, so it does not really change much now.
Co-Authored-By: William Hilton <wmhilton@gmail.com>
|
@P0lip I made a few fixes a very subtle off-by-one thingy.... the pre-rendered one didn't render the "half-row" at the bottom also don't use z-index it's evil and simple to avoid in this case by re-ordering the divs lol. 👍 oh and did you mean for it to have a |
|
of course I broke the tests |
|
blegh. could not figure out the tests. fine, keep the flickering half-row at the bottom. |
That's a feature? We want to have that cut to indicate the content can be scrolled |
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #42
Closes #45