fix: array subtype #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
reviewed
Aug 28, 2019
Contributor
P0lip
left a comment
P0lip
left a comment
There was a problem hiding this comment.
Looking okay. I'd just extend inferType fn.
export function inferType(node: JSONSchema4): JSONSchema4TypeName | undefined {
if ('properties' in node) {
return SchemaKind.Object;
}
if ('items' in node) {
return SchemaKind.Array;
}
if ('type' in node) {
return node.type;
}
return;
}
src/utils/getNodeType.ts
Outdated
| import { JSONSchema4, JSONSchema4TypeName } from 'json-schema'; | ||
| import { inferType } from './inferType'; | ||
|
|
||
| export function getNodeType(node: JSONSchema4): JSONSchema4TypeName | JSONSchema4TypeName[] | undefined { |
Contributor
There was a problem hiding this comment.
Let's just extend inferType function.
Author
There was a problem hiding this comment.
That was actually my first intention but thought it might not be precise enough as it is used separately in few places in the code already.
I'll move it there. But if so shouldn't type be checked before properties and items?
Contributor
There was a problem hiding this comment.
Yeah, it could be moved to the top.
P0lip
reviewed
Aug 28, 2019
| import { Property, Types } from '../shared'; | ||
|
|
||
| describe('Property component', () => { | ||
| it('should render Types with propper type and subtype', () => { |
Collaborator
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Changes: