Skip to content

Conversation

@P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 9, 2019

Fixes #50 and perhaps #44

image
image

Side note,
I need to make heavier use of tagged union types, so that we don't need to to these as Something explicit type assertions. This will result in much cleaner code - will do it at some point.

@P0lip P0lip added the t/bug Something isn't working label Sep 9, 2019
@P0lip P0lip requested review from lottamus and marbemac September 9, 2019 12:01
@P0lip P0lip self-assigned this Sep 9, 2019
Copy link
Contributor

@lottamus lottamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@P0lip P0lip merged commit f9e11b6 into master Sep 9, 2019
@P0lip P0lip deleted the fix/array-of-all branch September 9, 2019 18:23
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 2.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released t/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rendering array of allOf only works when in a schema with another allOf property

4 participants