fix: monorepo bundle #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallachari
requested review from
a team,
marcelltoth and
mmiask
and removed request for
a team
marcelltoth
reviewed
Jul 15, 2021
Contributor
marcelltoth
left a comment
marcelltoth
left a comment
There was a problem hiding this comment.
Looks good to me! As you said, let's wait for #88 then merge master to gain confidence.
Author
|
Looks good |
marcelltoth
approved these changes
Jul 16, 2021
Contributor
marcelltoth
left a comment
marcelltoth
left a comment
There was a problem hiding this comment.
Looks good
Now this is the confidence we should achieve everywhere! You just look at the tests, they all pass, so you're not worried about breaking stuff. See your work shine @mpodlasin 🚀
Code still looks great, assuming you tested the bundle script in elements @mallachari, it's good to go.
Author
|
I briefly tested it with all elements repos and one example. It just requires changing tsconfig to use |
Collaborator
|
🎉 This PR is included in version 9.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #89
Following #83 there's one more resolving to be done.
I've tested it with elements packages and they build solid esm.
Still would be good to wait for #90 before merging this one so we have it tested properly.