satellite/orders: remove unused flag

Change-Id: If73905c20142d40542baf6d843c86c920de9a489

Author: mniewrzal

private/testplanet/satellite.go

@@ -445,7 +445,6 @@ func (planet *Planet) newSatellite(ctx context.Context, prefix string, index int
 	config.Debug.Addr = ""
 	config.Reputation.AuditHistory.OfflineDQEnabled = false
 	config.Server.Config.Extensions.Revocation = false
-	config.Orders.OrdersSemaphoreSize = 0
 	config.Checker.NodeFailureRate = 0
 	config.Audit.MaxRetriesStatDB = 0
 	config.GarbageCollection.RetainSendTimeout = 0

satellite/api.go

@@ -406,7 +406,6 @@ func NewAPI(log *zap.Logger, full *identity.FullIdentity, db DB,
 			satelliteSignee,
 			peer.Orders.DB,
 			peer.DB.NodeAPIVersion(),
-			config.Orders.OrdersSemaphoreSize,
 			peer.Orders.Service,
 		)
 

satellite/console-api.go

@@ -313,7 +313,6 @@ func NewConsoleAPI(log *zap.Logger, full *identity.FullIdentity, db DB,
 			satelliteSignee,
 			peer.Orders.DB,
 			peer.DB.NodeAPIVersion(),
-			config.Orders.OrdersSemaphoreSize,
 			peer.Orders.Service,
 		)
 

satellite/orders/endpoint.go

@@ -177,27 +177,16 @@ type Endpoint struct {
 	satelliteSignee  signing.Signee
 	DB               DB
 	nodeAPIVersionDB nodeapiversion.DB
-	ordersSemaphore  chan struct{}
 	ordersService    *Service
 }
 
 // NewEndpoint new orders receiving endpoint.
-//
-// ordersSemaphoreSize controls the number of concurrent clients allowed to submit orders at once.
-// A value of zero means unlimited.
-func NewEndpoint(log *zap.Logger, satelliteSignee signing.Signee, db DB, nodeAPIVersionDB nodeapiversion.DB,
-	ordersSemaphoreSize int, ordersService *Service) *Endpoint {
-	var ordersSemaphore chan struct{}
-	if ordersSemaphoreSize > 0 {
-		ordersSemaphore = make(chan struct{}, ordersSemaphoreSize)
-	}
-
+func NewEndpoint(log *zap.Logger, satelliteSignee signing.Signee, db DB, nodeAPIVersionDB nodeapiversion.DB, ordersService *Service) *Endpoint {
 	return &Endpoint{
 		log:              log,
 		satelliteSignee:  satelliteSignee,
 		DB:               db,
 		nodeAPIVersionDB: nodeAPIVersionDB,
-		ordersSemaphore:  ordersSemaphore,
 		ordersService:    ordersService,
 	}
 }

satellite/orders/service.go

@@ -34,12 +34,11 @@ var (
 
 // Config is a configuration struct for orders Service.
 type Config struct {
-	EncryptionKeys      EncryptionKeys `help:"encryption keys to encrypt info in orders" default:""`
-	Expiration          time.Duration  `help:"how long until an order expires" default:"24h" testDefault:"168h"` // default is 1 day
-	FlushBatchSize      int            `help:"how many items in the rollups write cache before they are flushed to the database" devDefault:"20" releaseDefault:"1000" testDefault:"10"`
-	FlushInterval       time.Duration  `help:"how often to flush the rollups write cache to the database" devDefault:"30s" releaseDefault:"1m" testDefault:"$TESTINTERVAL"`
-	NodeStatusLogging   bool           `hidden:"true" help:"deprecated, log the offline/disqualification status of nodes" default:"false" testDefault:"true"`
-	OrdersSemaphoreSize int            `help:"how many concurrent orders to process at once. zero is unlimited" default:"2"`
+	EncryptionKeys    EncryptionKeys `help:"encryption keys to encrypt info in orders" default:""`
+	Expiration        time.Duration  `help:"how long until an order expires" default:"24h" testDefault:"168h"` // default is 1 day
+	FlushBatchSize    int            `help:"how many items in the rollups write cache before they are flushed to the database" devDefault:"20" releaseDefault:"1000" testDefault:"10"`
+	FlushInterval     time.Duration  `help:"how often to flush the rollups write cache to the database" devDefault:"30s" releaseDefault:"1m" testDefault:"$TESTINTERVAL"`
+	NodeStatusLogging bool           `hidden:"true" help:"deprecated, log the offline/disqualification status of nodes" default:"false" testDefault:"true"`
 
 	DownloadTailToleranceOverrides string `help:"how many nodes should be used for downloads for certain k. must be >= k. if not specified, this is calculated from long tail tolerance. format is comma separated like k-d,k-d,k-d e.g. 29-35,3-5." default:""`
 }

satellite/satellite-config.yaml.lock

@@ -1100,9 +1100,6 @@ identity.key-path: /root/.local/share/storj/identity/satellite/identity.key
 # how often to flush the rollups write cache to the database
 # orders.flush-interval: 1m0s
 
-# how many concurrent orders to process at once. zero is unlimited
-# orders.orders-semaphore-size: 2
-
 # default AS OF SYSTEM TIME for service
 # overlay.as-of-system-time: -10s