storagenode/hashstore: windows fixes

operators reported errors going from 1.141.4 to
1.142.4 on windows and the errors indicated that
it was during atomic file rename. the two changes
during that time were the switch from os.Rename
to platform.Rename and the removal of share
permissions on CreateFile.

this change puts back the share permissions for
the CreateFile api on windows. dunno why i removed
it in the first place. it does keep the os.Rename
to platform.Rename change because it should be the
same except for the windows.MOVEFILE_WRITE_THROUGH
which should make it more safe for atomic rename
because it's documented to make it not return
until the file is actually moved on disk.

the tests pass on wine which is the best i can do
right now.

Change-Id: Ibe80fb078a928890d2badff5f99314777cabd8cc

Author: zeebo

storagenode/hashstore/crash_test.go

@@ -25,24 +25,17 @@ import (
 )
 
 func TestMain(m *testing.M) {
-	if os.Getenv("STORJ_HASHSTORE_CRASH_TEST") != "" {
-		if err := runCrashServer(context.Background()); err != nil {
+	if dir := os.Getenv("STORJ_HASHSTORE_CRASH_TEST"); dir != "" {
+		if err := runCrashServer(context.Background(), dir); err != nil {
 			log.Fatalf("%+v", err)
 		}
 		os.Exit(0)
 	}
-
 	os.Exit(m.Run())
 }
 
-func runCrashServer(ctx context.Context) error {
-	tmpDir, err := os.MkdirTemp("", "hashstore-crash-test-*")
-	if err != nil {
-		return errs.Wrap(err)
-	}
-	fmt.Println(tmpDir)
-
-	db, err := New(ctx, CreateDefaultConfig(TableKind_HashTbl, false), tmpDir, "", nil, nil, nil)
+func runCrashServer(ctx context.Context, dir string) error {
+	db, err := New(ctx, CreateDefaultConfig(TableKind_HashTbl, false), dir, "", nil, nil, nil)
 	if err != nil {
 		return errs.Wrap(err)
 	}
@@ -102,9 +95,10 @@ func runCrashServer(ctx context.Context) error {
 func TestCorrectDuringCrashes(t *testing.T) {
 	ctx := t.Context()
 
-	// re-exec the process with the STORJ_HASHSTORE_CRASH_TEST env var set
+	// re-exec the process with the STORJ_HASHSTORE_CRASH_TEST env var set to a temp dir.
+	dir := t.TempDir()
 	cmd := exec.Command(os.Args[0], os.Args[1:]...)
-	cmd.Env = append(os.Environ(), "STORJ_HASHSTORE_CRASH_TEST=server")
+	cmd.Env = []string{"STORJ_HASHSTORE_CRASH_TEST=" + dir}
 
 	// give a stdin handle to the process so that it can know if the parent process dies.
 	cmdStdinR, cmdStdinW, err := os.Pipe()
@@ -113,45 +107,23 @@ func TestCorrectDuringCrashes(t *testing.T) {
 	defer func() { _ = cmdStdinW.Close() }()
 	cmd.Stdin = cmdStdinR
 
-	// give a stdout handle so we can read the keys it prints out.
-	var stdout lockedBuffer
+	// capture stdout and stderr so we can read the keys it prints out and any errors.
+	var stdout, stderr bytes.Buffer
 	cmd.Stdout = &stdout
-
-	// give a stderr handle so we can look at any errors it prints out.
-	var stderr bytes.Buffer
 	cmd.Stderr = &stderr
 
 	// start the command and create a signal to keep track of when it finishes.
 	assert.NoError(t, cmd.Start())
 	var finished drpcsignal.Signal
 	go func() { finished.Set(cmd.Wait()) }()
 
-	// wait until the directory is printed.
-	var dir string
-	for {
-		if prefix, _, ok := strings.Cut(stdout.String(), "\n"); ok {
-			dir = prefix
-			break
-		}
-
-		select {
-		case <-finished.Signal():
-			t.Fatal("process exited early:", finished.Err())
-		case <-time.After(time.Millisecond):
-		}
-	}
-
-	// ensure the directory is what we expect and clean it up when we're done.
-	assert.That(t, strings.HasPrefix(dir, os.TempDir()))
-	defer func() { _ = os.RemoveAll(dir) }()
-
 	// wait until we have at least 3 hashtbl files (middle of a compaction).
 	for {
 		paths := allFiles(t, dir)
 
 		hashtbls := 0
 		for _, path := range paths {
-			if strings.Contains(path, "meta/hashtbl-") {
+			if strings.Contains(path, "hashtbl-") {
 				hashtbls++
 			}
 		}
@@ -172,12 +144,8 @@ func TestCorrectDuringCrashes(t *testing.T) {
 
 	// grab all of the keys out of stdout.
 	var keys []Key
-	for _, line := range strings.Split(stdout.String(), "\n")[1:] {
-		if strings.TrimSpace(line) == "" {
-			continue
-		}
-
-		key, err := storj.PieceIDFromString(line)
+	for line := range bytes.Lines(stdout.Bytes()) {
+		key, err := storj.PieceIDFromString(string(line))
 		assert.NoError(t, err)
 		keys = append(keys, key)
 	}
@@ -197,22 +165,3 @@ func TestCorrectDuringCrashes(t *testing.T) {
 		assert.Equal(t, dataFromKey(key), got)
 	}
 }
-
-type lockedBuffer struct {
-	buf bytes.Buffer
-	mu  sync.Mutex
-}
-
-func (a *lockedBuffer) String() string {
-	a.mu.Lock()
-	defer a.mu.Unlock()
-
-	return a.buf.String()
-}
-
-func (a *lockedBuffer) Write(p []byte) (n int, err error) {
-	a.mu.Lock()
-	defer a.mu.Unlock()
-
-	return a.buf.Write(p)
-}

storagenode/hashstore/platform/file_windows.go

@@ -31,7 +31,7 @@ func CreateFile(path string) (*os.File, error) {
 	handle, err := windows.CreateFile(
 		pathPtr,
 		windows.GENERIC_READ|windows.GENERIC_WRITE,
-		0,
+		windows.FILE_SHARE_READ|windows.FILE_SHARE_WRITE|windows.FILE_SHARE_DELETE,
 		nil,
 		windows.CREATE_NEW,
 		windows.FILE_ATTRIBUTE_NORMAL,