Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive changelog and link addon changelog to root #221

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 26, 2023

Closes #220

@pocka I tried to configure Auto to output CHANGELOG.md to the root, but didn't see an option for that. For now I've created a symbolic link from the package changelog to the root directory. If you have better ideas I'm open to trying other things. WDYT?

@shilman shilman added skip-release Preserve the current version when merged documentation Changes only affect the documentation labels Dec 26, 2023
@pocka
Copy link
Collaborator

pocka commented Dec 26, 2023

@pocka I tried to configure Auto to output CHANGELOG.md to the root, but didn't see an option for that. For now I've created a symbolic link from the package changelog to the root directory. If you have better ideas I'm open to trying other things. WDYT?

Unfortunately GitHub (still) does not support symlink on their web UI...
https://github.com/storybookjs/addon-designs/blob/shilman/fix-changelog/CHANGELOG.md

Maybe having a <repo root>/CHANGELOG.md that have something like below would be good enough (better than nothing).

See <./packages/storybook-addon-designs/CHANGELOG.md>

@shilman
Copy link
Member Author

shilman commented Dec 26, 2023

@pocka fair point. updated!

@pocka
Copy link
Collaborator

pocka commented Dec 26, 2023

Thanks, looks good to me!

@shilman shilman merged commit 9112e46 into master Dec 26, 2023
4 checks passed
@shilman shilman deleted the shilman/fix-changelog branch December 26, 2023 09:03
@shilman
Copy link
Member Author

shilman commented Dec 26, 2023

Thanks so much for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog & Git version tags
2 participants