Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack module rule regex updated for .postcss and .pcss file ext #17

Closed
wants to merge 3 commits into from
Closed

Conversation

Asim-Tahir
Copy link

@Asim-Tahir Asim-Tahir commented Mar 8, 2021

Added optional .postcss and .pcss file extension regex. It's still support .css file extension.

@phated
Copy link
Contributor

phated commented Mar 8, 2021

I've not seen this as a common pattern/file extension. Do you have a link to this recommendation?

@Asim-Tahir
Copy link
Author

Asim-Tahir commented Mar 8, 2021

First I saw the .pcss and .postcss file extension here.

@Asim-Tahir Asim-Tahir changed the title Webpack module rule regex updated to .postcss file ext Webpack module rule regex updated for .postcss and .pcss file ext Mar 8, 2021
@Asim-Tahir
Copy link
Author

Asim-Tahir commented Mar 15, 2021

Any update 👀

@Asim-Tahir
Copy link
Author

@knightly-bot build this

@knightly-bot
Copy link

This repo does not have Knightly configured yet.

Please open a request issue to enable this repo in knightlyjs/tasks first.

@antfu
Copy link

antfu commented Mar 25, 2021

@knightly-bot build this

@knightly-bot
Copy link

Nightly Build

🌒 Knightly build enabled, release every night at 00:00 UTC (skip if no change)

📦 npm package

Only match:
- .css
- .pcss
- .postcss
@Asim-Tahir Asim-Tahir closed this Apr 2, 2021
@Asim-Tahir Asim-Tahir deleted the patch-1 branch April 2, 2021 20:13
@zakkor
Copy link

zakkor commented May 13, 2021

We need this too, or at least an option to make it configurable.

@RumyantsevMichael
Copy link

I believe you should support .pcss as it is widely used.
For instance, webstorm supports this extension out of the box (https://plugins.jetbrains.com/plugin/8578-postcss)

@fvanwijk
Copy link

.postcss extension needs to be matched for .vue files that have <style lang="postcss">

@alkorlos
Copy link

alkorlos commented Jul 31, 2021

@phated Yes I have a link, official twitter PostCSS recommendation use .pcss extension for PostCSS based sources.
https://twitter.com/PostCSS/status/661645290622083073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants