Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support flat config and eslint v9 #152

Closed
wants to merge 8 commits into from

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Mar 28, 2024

Issue: #135

What Changed

I've supported ESLint flat configuration and eslint v9
This PR has compatible for legacy style configuration and compatible eslint API using.

So to maintain compatibility, we provide a preset with the flat namespace.

flat config example is here:

import storybook from 'eslint-plugin-storybook'

export default [
  // add more generic rulesets here, such as:
  // js.configs.recommended,
  ...storybook.configs['flat/recommended'],

  // something ...
]

This implementation is based on eslint-plugin-vue, which has several presets to support Vue 3 and Vue 2.
docs is here:
https://eslint.vuejs.org/user-guide/#usage

Checklist

Check the ones applicable to your change:

  • Ran pnpm run update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

@shilman @ndelangen
I used to help out some with Vue support at Storybook.
storybookjs/storybook#1267
storybookjs/storybook#1477
storybookjs/storybook#1595

I am happy to contribute to storybook for the first time in 7 years again! ☺️

@yannbf
Copy link
Member

yannbf commented Mar 28, 2024

This is fantastic @kazupon! Thanks a lot for your contribution(s)! Happy to see you're back into contributing. I'll take a look into this PR once I have some focus time here <3

@shilman
Copy link
Member

shilman commented Mar 28, 2024

@kazupon welcome back & thanks so much for your contribution -- it's great to see you again! 🙌

@heddn
Copy link

heddn commented Apr 8, 2024

Eslint v9 just was released, making the enhancements here more important.

@kazupon kazupon changed the title feat: support flat config feat: support flat config and eslint v9 Apr 10, 2024
@kazupon
Copy link
Member Author

kazupon commented Apr 10, 2024

I've just supported comatibility for eslint v8 and v9

@yannbf
Copy link
Member

yannbf commented May 17, 2024

Hey @kazupon sorry for the long time, I was only able to check this now. I created a new PR based on your branch at #156 so that we can get CI checks and canary releases to test out (given that you did the changes via a fork, they were not triggered). Let's continue working from there!

@yannbf yannbf closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants