-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support flat config and eslint v9 #152
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fantastic @kazupon! Thanks a lot for your contribution(s)! Happy to see you're back into contributing. I'll take a look into this PR once I have some focus time here <3 |
@kazupon welcome back & thanks so much for your contribution -- it's great to see you again! 🙌 |
Eslint v9 just was released, making the enhancements here more important. |
kazupon
changed the title
feat: support flat config
feat: support flat config and eslint v9
Apr 10, 2024
I've just supported comatibility for eslint v8 and v9 |
1 task
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #135
What Changed
I've supported ESLint flat configuration and eslint v9
This PR has compatible for legacy style configuration and compatible eslint API using.
So to maintain compatibility, we provide a preset with the
flat
namespace.flat config example is here:
This implementation is based on
eslint-plugin-vue
, which has several presets to support Vue 3 and Vue 2.docs is here:
https://eslint.vuejs.org/user-guide/#usage
Checklist
Check the ones applicable to your change:
pnpm run update-all
Change Type
Indicate the type of change your pull request is:
maintenance
documentation
patch
minor
major
@shilman @ndelangen
I used to help out some with Vue support at Storybook.
storybookjs/storybook#1267
storybookjs/storybook#1477
storybookjs/storybook#1595
I am happy to contribute to storybook for the first time in 7 years again!☺️