-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue: Tweak vue app #1477
Vue: Tweak vue app #1477
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.2 #1477 +/- ##
==============================================
Coverage ? 20.29%
==============================================
Files ? 240
Lines ? 5183
Branches ? 630
==============================================
Hits ? 1052
Misses ? 3664
Partials ? 467
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kazupon I 'rebased' this unto the 3.2 branch. I had some merge conflicts on the 👍 |
@ndelangen Thanks! I checked ! OK! 🙆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and merging! Will release a new alpha soon!
Issue:
What I did
Refactoring of vue app
How to test
cd examples/vue-kitchen-sink
npm link ../../app/vue
npm run storybook