Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: Tweak vue app #1477

Merged
merged 6 commits into from
Jul 20, 2017
Merged

Vue: Tweak vue app #1477

merged 6 commits into from
Jul 20, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Jul 16, 2017

Issue:

What I did

Refactoring of vue app

How to test

  • cd examples/vue-kitchen-sink
  • npm link ../../app/vue
  • npm run storybook

@codecov
Copy link

codecov bot commented Jul 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (release/3.2@852ee89). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.2    #1477   +/-   ##
==============================================
  Coverage               ?   20.29%           
==============================================
  Files                  ?      240           
  Lines                  ?     5183           
  Branches               ?      630           
==============================================
  Hits                   ?     1052           
  Misses                 ?     3664           
  Partials               ?      467
Impacted Files Coverage Δ
app/vue/src/client/preview/render.js 0% <ø> (ø)
app/vue/src/client/preview/client_api.js 86.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852ee89...d9ff515. Read the comment docs.

@kazupon kazupon added the vue label Jul 17, 2017
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen
Copy link
Member

@kazupon I 'rebased' this unto the 3.2 branch. I had some merge conflicts on the package.jsons. Can you check if all the changes you made are still in place and working correctly?

👍

@kazupon
Copy link
Member Author

kazupon commented Jul 20, 2017

@ndelangen Thanks! I checked ! OK! 🙆

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and merging! Will release a new alpha soon!

@shilman shilman merged commit 0daec90 into storybookjs:release/3.2 Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants