-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add necessary packages to devDependencies #14
base: main
Are you sure you want to change the base?
Conversation
@aschlumpf — Thank you for your (first! 🥳) contribution! I've assigned a relevant maintainer to take a look as soon as they're able. |
Love this PR! The prettier dependency |
👍 this'll unlock some of our prettier issues ❤️ |
@shilman Any updates here for merging this in? |
@shilman +1000 The prettier dependencies cause a bunch of problems, and there doesn't seem to be a way to override this. Would love to update prettier to 2.8.1 + keep it up to date!! |
This update to the |
Any update on this? |
@shilman Can we please try and get this merged soon? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
@chrisburkejr Thank you, it says I need approval from someone with write access in order to merge. |
Issue: #6
What Changed
Currently, there are dependencies which should be devDependencies in the external dependencies. This issue causes projects which use Storybook, using this package as a dependency, to install these packages. The
@types
packages which are installed are added to these projects' installed types, forcing dependencies to be type checked at these particular versions. There is no workaround built into TypeScript for installing transient@types
from packages, see microsoft/TypeScript#18588.This issue blocks my project from upgrading to Storybook
6.5.9
, aslodash
is having its types checked when we have version4.17.21
installed and do not enforce strong typing on our use oflodash
. The other changes are just good practice.How to test
Run a build and run the tests.
Change Type
maintenance
documentation
patch
minor
major