Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-Controls: Next-generation knobs #10834

Merged
merged 19 commits into from May 26, 2020
Merged

Addon-Controls: Next-generation knobs #10834

merged 19 commits into from May 26, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented May 19, 2020

Issue: #10728

What I did

addon-controls-hero

Storybook Controls provides UI to interactive to edit the properties of your components and stories. It replaces Storybook Knobs and offers the following improvements:

  • Convenience. Auto-generated based on your components (even for non-React frameworks)
  • Compatibility. Controls is based on Storybook Args, so stories written for Controls will be portable:
    • Documentation. Controls 100% compatible with Storybook Docs.
    • Testing. Re-use stories directly inside testing tools like Jest.
    • And more. Re-use stories in design and development tools as Args is adopted.

How to test

See updated stories in official-storybook

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and a question

addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
ndelangen and others added 2 commits May 19, 2020 13:55
Co-authored-by: Tom Coleman <tom@thesnail.org>
Co-authored-by: Tom Coleman <tom@thesnail.org>
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome stuff!! 🚀
Sorry for so many comments hehe I'm requesting changes on the FIXME parts specifically, we don't want that to be in the docs, right?

addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/src/constants.ts Outdated Show resolved Hide resolved
@shilman shilman requested a review from igor-dv as a code owner May 21, 2020 02:33
@shilman
Copy link
Member Author

shilman commented May 22, 2020

Addons___Docs___ButtonGroup_-_Basic_⋅_Storybook

addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
addons/controls/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants