fix: resolve customAccessToken warning error that causes app to crash #3934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the present implementation
verifyUserRelations(Model)
assumes thatModel.relations.accessTokens
is always set, and as a result maycrash when trying to access
polymorphic
property of that relation.It seems the intention is to check whether the the following conditions are met:
This commit fixes the problem by accounting for the case where the
accessTokens relation was not correctly set up.
This pull request supersedes #3921, which was opened against a wrong branch (
3.x-latest
)./cc @ryanxwelch