Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore: ["first-nested"] to custom-property-empty-line-before #3104

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Add ignore: ["first-nested"] to custom-property-empty-line-before #3104

merged 2 commits into from
Jan 5, 2018

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jan 4, 2018

Which issue, if any, is this issue related to?

Closes #3102

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

ntwb
ntwb approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntwb ntwb mentioned this pull request Jan 5, 2018
Merged
hudochenkov
hudochenkov approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hudochenkov
hudochenkov requested changes Jan 5, 2018
View reviewed changes
lib/rules/custom-property-empty-line-before/README.md Outdated
```css
a {
--foo: pink;
--bar: red;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line before.

@jeddy3
Copy link
Member Author

jeddy3 commented Jan 5, 2018

Fixed

@jeddy3 jeddy3 merged commit 1acb588 into master Jan 5, 2018
@jeddy3 jeddy3 deleted the issue-3102 branch January 5, 2018 10:45
@jeddy3
Copy link
Member Author

jeddy3 commented Jan 5, 2018

  • Added: ignore: ["first-nested"] to custom-property-empty-line-before (#3104).

This was referenced Feb 18, 2018
Closed
Merged
Merged
Closed
@kaelig kaelig mentioned this pull request Feb 21, 2018
Closed
This was referenced Mar 14, 2018
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore: ["first-nested"] to custom-property-empty-line-before
3 participants
@jeddy3 @hudochenkov @ntwb