Skip to content

Conversation

oleburghardt
Copy link
Contributor

This PR adds a follow-up on Heated Cylinders with Conjugate Heat Transfer to the tutorials catalogue.

It is about how to turn a steady simulation into an unsteady one within the multizone framework, based on CHT but not exclusively applicable for such cases.

As it's a rather small one, @talbring considers to include some more specifics on his work on paraview multiblock files.

This tutorial relates to the Unsteady CHT pull request.

@pr-triage pr-triage bot added the PR: draft label Feb 4, 2020
@oleburghardt oleburghardt changed the title Unsteady cht tutorial Unsteady CHT tutorial Feb 4, 2020
@oleburghardt oleburghardt mentioned this pull request Feb 5, 2020
5 tasks
Comment on lines 30 to 36
%
TIME_DOMAIN = YES
%
%
TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
%
%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the related PR su2code/SU2#854

---

<br>
<iframe width="560" height="315" src="https://www.youtube.com/embed/MqN8GalSyzk" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


### Problem Setup

The problem setup is the same as in the [heated cylinders with conjugate heat transfer tutorial](/tutorials/Inc_Heated_Cylinders/) except for the density. It is increased in all zones by a factor of 100 so that for the flow we obtain a Reynolds number of 4000 which will make it unsteady. Thus we set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...which will make it unsteady. sounds a bit weird albeit true


- Time domain and time-marching config file options (plus related ones) for unsteady simulations
- Use of time iterations, outer and inner iterations
- Paraview multiblock output
Copy link
Contributor

@TobiKattmann TobiKattmann Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point (pw multiblock) should get some explanation below as it is mentioned here but never down below

edit: yeah... I should read the inital PR-comment before commenting 🙈

* [Laminar Buoyancy-driven Cavity](/tutorials/Inc_Laminar_Cavity/)
Simulation of internal, laminar, incompressible flow in a differentially-heated cavity under the influence of gravity (classical natural convection case).
* [Streamwise Periodicity](/tutorials/Inc_Streamwise_Periodic/)
* [Streamwise Periodicity](/tutorials/Inc_Streamwise_Periodic/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These added spaces trigger line break here. Added for consistency

@TobiKattmann TobiKattmann marked this pull request as ready for review March 4, 2021 12:24
@TobiKattmann
Copy link
Contributor

Although this could be directly merged into master (as the necessary code is already there from su2code/SU2/pull/854) I think choosing develop might avoid some problems down the merging road.

I'll test 🔍 this Tutorial a bit and then merge it if no-one (especially @oleburghardt ;) ) has comments or thinks otherwise.

@oleburghardt
Copy link
Contributor Author

Thanks @TobiKattmann for resurrecting this and updating the links. Did you check whether the unsteady CHT case from the tutorial repository works fine with current develop? Apart from that, I don't really remember the reason why we lost sight of this one...

Is there an official guideline how merging into master is handled for the su2code.github.io world?

@TobiKattmann
Copy link
Contributor

To quote the official guideline Article 2 §4(b): "You shall merge the websites develop into master whenever the main gig (su2 itself) does so." :) The reasoning of the regulators back in the day 👴 was because when a feature comes with a tutorial you don't want to have the tutorial live before the feature is in master. Same goes then the tutorials folder. I guess it makes sense to step those 4 (su2, Testcases, tutorial, website) in unisono. I'll keep an eye on the next su2 master as I have that streamwise stuff in there as well ;)

I'll play around a bit with your Testcase and unsteady cht in the next days and will report 👍

@TobiKattmann
Copy link
Contributor

TobiKattmann commented Mar 5, 2021

But that didn't really work in the past because otherwise your #49 would already be merged into master :)

@oleburghardt
Copy link
Contributor Author

But that didn't really work in the past because otherwise your #49 would already be merged into master :)

Maybe we could bring up next Wednesday how to handle the develop branch in this and the Tutorials repository, @pcarruscag @TobiKattmann ?

@TobiKattmann
Copy link
Contributor

TobiKattmann commented Mar 18, 2021

@oleburghardt imo we can merge this rn into develop. With the next su2 master we just merge develop into master for the website and tutorials as well and we are good. If /su2code/SU2/pull/1226 doesn't make it into develop over at the code we can still quickly remove the links to it and we're good. With website, Tutorials and code togehter I guess it always is a bit wobbly :)

So if you don't have any more changes than feel free to merge

@Nicola-Fonzi
Copy link
Contributor

Dear all,

I noticed that this PR remained open even if ready, shall we merge it?

@TobiKattmann
Copy link
Contributor

I will make a few adjustments because this was meant to go in with su2code/SU2/pull/1226 which is currently closed by the stall bot. Especially the config options do not have to be changed.

@TobiKattmann
Copy link
Contributor

Now that su2code/SU2/pull/1226 is merged this can be merged into website develop. The code PR contained change in option names that were already considered here. Thats why the merge was so delayed.

@TobiKattmann TobiKattmann merged commit b55fb2a into develop Jul 31, 2021
@pcarruscag pcarruscag deleted the unsteady_cht_tutorial branch June 4, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants